Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 1217403003: Enable ninja_confirm_noop by default (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import pipes 5 import pipes
6 6
7 from recipe_engine.config import config_item_context, ConfigGroup 7 from recipe_engine.config import config_item_context, ConfigGroup
8 from recipe_engine.config import Dict, List, Single, Static, Set, BadConf 8 from recipe_engine.config import Dict, List, Single, Static, Set, BadConf
9 from recipe_engine.config_types import Path 9 from recipe_engine.config_types import Path
10 10
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 def win_analyze(c): 226 def win_analyze(c):
227 c.gyp_env.GYP_DEFINES['win_analyze'] = '1' 227 c.gyp_env.GYP_DEFINES['win_analyze'] = '1'
228 c.gyp_env.GYP_DEFINES['fastbuild'] = '2' 228 c.gyp_env.GYP_DEFINES['fastbuild'] = '2'
229 c.gyp_env.GYP_DEFINES['use_goma'] = 0 229 c.gyp_env.GYP_DEFINES['use_goma'] = 0
230 230
231 @config_ctx(group='builder') 231 @config_ctx(group='builder')
232 def ninja(c): 232 def ninja(c):
233 if c.TARGET_PLATFORM == 'ios': 233 if c.TARGET_PLATFORM == 'ios':
234 c.gyp_env.GYP_GENERATORS.add('ninja') 234 c.gyp_env.GYP_GENERATORS.add('ninja')
235 235
236 if c.TARGET_PLATFORM != 'android':
237 ninja_confirm_noop(c)
238
236 c.compile_py.build_tool = 'ninja' 239 c.compile_py.build_tool = 'ninja'
237 240
238 out_path = 'out' 241 out_path = 'out'
239 if c.TARGET_CROS_BOARD: 242 if c.TARGET_CROS_BOARD:
240 out_path += '_%s' % (c.TARGET_CROS_BOARD,) 243 out_path += '_%s' % (c.TARGET_CROS_BOARD,)
241 c.build_dir = Path('[CHECKOUT]', out_path) 244 c.build_dir = Path('[CHECKOUT]', out_path)
242 245
243 @config_ctx(group='builder') 246 @config_ctx(group='builder')
244 def msvs(c): 247 def msvs(c):
245 if c.HOST_PLATFORM != 'win': # pragma: no cover 248 if c.HOST_PLATFORM != 'win': # pragma: no cover
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 def chromium_deterministic_build(c): 788 def chromium_deterministic_build(c):
786 c.gyp_env.GYP_DEFINES['dont_embed_build_metadata'] = 1 789 c.gyp_env.GYP_DEFINES['dont_embed_build_metadata'] = 1
787 790
788 @config_ctx() 791 @config_ctx()
789 def chromium_mac_sdk_10_10(c): 792 def chromium_mac_sdk_10_10(c):
790 c.gyp_env.GYP_DEFINES['mac_sdk_min='] = '10.10' 793 c.gyp_env.GYP_DEFINES['mac_sdk_min='] = '10.10'
791 794
792 @config_ctx(includes=['chromium_clang']) 795 @config_ctx(includes=['chromium_clang'])
793 def cast_linux(c): 796 def cast_linux(c):
794 c.gyp_env.GYP_DEFINES['chromecast'] = 1 797 c.gyp_env.GYP_DEFINES['chromecast'] = 1
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698