Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: pkg/pkgbuild.status

Issue 1217353002: Fix pkgbuild tests after adding a pubspec on pkg/compiler (fix #23750) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/pkgbuild.status
diff --git a/pkg/pkgbuild.status b/pkg/pkgbuild.status
index a2c33a4e1b55d04341c52423345c47ba47b3db92..ef756a0c5c3ef002ad59a9412bcd449d0e389ec0 100644
--- a/pkg/pkgbuild.status
+++ b/pkg/pkgbuild.status
@@ -8,20 +8,18 @@ pkg/docgen: Pass, Slow
[ $use_repository_packages ]
pkg/analyzer: PubGetError
-pkg/compiler: PubGetError # Issue 23750
samples/third_party/angular_todo: Fail # angular needs to be updated
samples/third_party/todomvc_performance: Skip # dependencies are not in the repo
-third_party/pkg/package_config: PubGetError # Issue 23750
[ $use_public_packages ]
-pkg/compiler: PubGetError # Issue 23750
+pkg/compiler: PubGetError # js_ast is not published
Bill Hesse 2015/07/01 08:17:01 I would change this to Skip. We like to keep issu
Siggi Cherem (dart-lang) 2015/07/01 15:18:36 Done.
samples/third_party/angular_todo: Pass, Slow
third_party/pkg/async_await: Skip # Uses expect package.
Siggi Cherem (dart-lang) 2015/07/01 15:18:36 I also noted we no longer pull this package, so th
samples/third_party/todomvc_performance: Pass, Slow
[ $builder_tag == russian ]
samples/third_party/angular_todo: Fail # Issue 16356
-samples/third_party/dromaeo: Fail # Issue 23750
+samples/third_party/dromaeo: Fail # Issue 23760
[ $use_public_packages && $system == windows ]
samples/third_party/todomvc_performance: Fail # Issue 18086

Powered by Google App Engine
This is Rietveld 408576698