pkg/pkgbuild.status - Issue 1217353002: Fix pkgbuild tests after adding a pubspec on pkg/compiler (fix #23750)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/pkgbuild.status

Issue 1217353002: Fix pkgbuild tests after adding a pubspec on pkg/compiler (fix #23750) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « pkg/compiler/pubspec.yaml ('k') | tools/testing/dart/test_suite.dart » ('j') | tools/testing/dart/test_suite.dart » ('J')

OLD	NEW
1 # Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 samples/third_party/dromaeo: Pass, Slow	5 samples/third_party/dromaeo: Pass, Slow

6 samples/searchable_list: Pass, Slow	6 samples/searchable_list: Pass, Slow

7 pkg/docgen: Pass, Slow	7 pkg/docgen: Pass, Slow

8	8

9 [ $use_repository_packages ]	9 [ $use_repository_packages ]

10 pkg/analyzer: PubGetError	10 pkg/analyzer: PubGetError

11 pkg/compiler: PubGetError # Issue 23750

12 samples/third_party/angular_todo: Fail # angular needs to be updated	11 samples/third_party/angular_todo: Fail # angular needs to be updated

13 samples/third_party/todomvc_performance: Skip # dependencies are not in the repo	12 samples/third_party/todomvc_performance: Skip # dependencies are not in the repo

14 third_party/pkg/package_config: PubGetError # Issue 23750

15	13

16 [ $use_public_packages ]	14 [ $use_public_packages ]

17 pkg/compiler: PubGetError # Issue 23750	15 pkg/compiler: PubGetError # js_ast is not published
	Bill Hesse 2015/07/01 08:17:01 I would change this to Skip. We like to keep issu I would change this to Skip. We like to keep issue numbers on all failures, but I guess just commenting a Skip with the reason is fine. Unless you think it is a good idea to have a test that intentionally fails. Siggi Cherem (dart-lang) 2015/07/01 15:18:36 Done. Show quoted text On 2015/07/01 08:17:01, Bill Hesse wrote: > I would change this to Skip. We like to keep issue numbers on all failures, but > I guess just commenting a Skip with the reason is fine. > Unless you think it is a good idea to have a test that intentionally fails. Done.
18 samples/third_party/angular_todo: Pass, Slow	16 samples/third_party/angular_todo: Pass, Slow

19 third_party/pkg/async_await: Skip # Uses expect package.	17 third_party/pkg/async_await: Skip # Uses expect package.
	Siggi Cherem (dart-lang) 2015/07/01 15:18:36 I also noted we no longer pull this package, so th I also noted we no longer pull this package, so this line wasn't needed anymore.
20 samples/third_party/todomvc_performance: Pass, Slow	18 samples/third_party/todomvc_performance: Pass, Slow

21	19

22 [ $builder_tag == russian ]	20 [ $builder_tag == russian ]

23 samples/third_party/angular_todo: Fail # Issue 16356	21 samples/third_party/angular_todo: Fail # Issue 16356

24 samples/third_party/dromaeo: Fail # Issue 23750	22 samples/third_party/dromaeo: Fail # Issue 23760

25	23

26 [ $use_public_packages && $system == windows ]	24 [ $use_public_packages && $system == windows ]

27 samples/third_party/todomvc_performance: Fail # Issue 18086	25 samples/third_party/todomvc_performance: Fail # Issue 18086

OLD	NEW