Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: components/policy/resources/policy_templates.json

Issue 1217333002: Add a group policy for hardware acceleration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/resources/policy_templates.json
diff --git a/components/policy/resources/policy_templates.json b/components/policy/resources/policy_templates.json
index 196aaf314a91d548b5a466d714d3c24bd09b8437..a2f2417c23fdc690bfcfbeef0f347f66ffadb777 100644
--- a/components/policy/resources/policy_templates.json
+++ b/components/policy/resources/policy_templates.json
@@ -123,7 +123,7 @@
# persistent IDs for all fields (but not for groups!) are needed. These are
# specified by the 'id' keys of each policy. NEVER CHANGE EXISTING IDs,
# because doing so would break the deployed wire format!
-# For your editing convenience: highest ID currently used: 302
+# For your editing convenience: highest ID currently used: 303
#
# Placeholders:
# The following placeholder strings are automatically substituted:
@@ -7397,6 +7397,26 @@
Only if allowCorporateKeyUsage is set to true for an extension, it can use any platform key marked for corporate usage to sign arbitrary data. This permission should only be granted if the extension is trusted to secure access to the key against attackers.''',
},
+ {
+ 'name': 'HardwareAccelerationModeEnabled',
bartfab (slow) 2015/07/01 09:16:54 How does this policy interact with Disable3DAPIs?
Zhenyao Mo 2015/07/01 17:56:08 Disable3DAPIs will be true if this is false. I add
+ 'type': 'main',
+ 'schema': { 'type': 'boolean' },
+ 'supported_on': ['chrome.*:45-', 'chrome_os:45-', 'android:45-'],
+ 'features': {
+ 'dynamic_refresh': False,
bartfab (slow) 2015/07/01 09:16:54 What happens if the policy value changes while Chr
Zhenyao Mo 2015/07/01 17:56:08 This is only applied at browser startup time, so e
+ 'per_profile': True,
bartfab (slow) 2015/07/01 09:16:54 Can this really be controlled on a per-profile bas
Zhenyao Mo 2015/07/01 17:56:08 Switched to global setting. You are right, this s
+ },
+ 'example_value': True,
+ 'id': 303,
+ 'caption': '''Use Hardware Acceleration When Available''',
bartfab (slow) 2015/07/01 09:16:54 Nit: Why is this in title case?
Zhenyao Mo 2015/07/01 17:56:08 Switch to regular text mode. FYI: I am simply fol
bartfab (slow) 2015/07/08 12:40:33 I guess our template could do with a bit of clean-
+ 'desc': '''Use hardware acceleration when available.
+
+ If you enable this setting, hardware acceleration will be enabled unless a certain GPU feature is blacklisted.
bartfab (slow) 2015/07/01 09:16:54 What is that "certain GPU feature" which disables
Zhenyao Mo 2015/07/01 17:56:07 For example, accelerated canvas 2D, or accelerated
+
+ If you disable this setting, no hardware acceleration will be disabled.
bartfab (slow) 2015/07/01 09:16:54 This sentence is broken.
Zhenyao Mo 2015/07/01 17:56:08 Done.
+
+ If this policy is left not set, it is equivalent to being enabled, see description above.''',
bartfab (slow) 2015/07/01 09:16:54 This is unnecessarily complex. How about: If this
Zhenyao Mo 2015/07/01 17:56:08 That doesn't cover the case of features being blac
bartfab (slow) 2015/07/08 12:40:33 A common way to solve this is to change the first
+ },
],
'messages': {
# Messages that are not associated to any policies.

Powered by Google App Engine
This is Rietveld 408576698