Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 121733002: Fix double-clicking in string interpolation (Closed)

Created:
6 years, 12 months ago by messick
Modified:
6 years, 12 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix double-clicking in string interpolation R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=31387

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 4 (0 generated)
messick
6 years, 12 months ago (2013-12-27 16:38:25 UTC) #1
scheglov
lgtm https://chromiumcodereview.appspot.com/121733002/diff/1/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java File editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java (right): https://chromiumcodereview.appspot.com/121733002/diff/1/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java#newcode63 editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java:63: assertDoubleClickSelection(content, "first$second$", "first", 101); Absolute constants like "101" ...
6 years, 12 months ago (2013-12-27 16:54:58 UTC) #2
messick
https://chromiumcodereview.appspot.com/121733002/diff/1/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java File editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java (right): https://chromiumcodereview.appspot.com/121733002/diff/1/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java#newcode63 editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartDoubleClickSelectorTest.java:63: assertDoubleClickSelection(content, "first$second$", "first", 101); On 2013/12/27 16:54:58, scheglov wrote: ...
6 years, 12 months ago (2013-12-27 17:05:11 UTC) #3
messick
6 years, 12 months ago (2013-12-27 17:06:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r31387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698