Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1217303004: Revert of Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (Closed)

Created:
5 years, 5 months ago by robertphillips
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1207353004/) Reason for revert: Still want to disable due to pref regression Original issue's description: > Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1219193002/) > > Reason for revert: > Blocking the roll > > Original issue's description: > > Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2 id:30001 of https://codereview.chromium.org/1210053003/) > > > > Reason for revert: > > Perf regression: https://code.google.com/p/chromium/issues/detail?id=505564 > > > > Original issue's description: > > > Fix SkTileImageFilter clipping/cropRect interaction issue > > > > > > BUG=499499 > > > > > > Committed: https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391 > > > > TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=499499 > > > > Committed: https://skia.googlesource.com/skia/+/ebaf6a69bf604c85185e23aca3fb93308e747ff5 > > TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com,reed@chromium.org,bsalomon@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=499499 > > Committed: https://skia.googlesource.com/skia/+/835510085062f055c04d8ea46d82831cfbe51793 TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org,bsalomon@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499499 Committed: https://skia.googlesource.com/skia/+/d312dcade1e54a687b18755b5b8efbc0d01ec69e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -162 lines) Patch
D gm/cropdisp.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 3 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue
5 years, 5 months ago (2015-07-06 14:58:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217303004/1
5 years, 5 months ago (2015-07-06 14:59:03 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 14:59:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d312dcade1e54a687b18755b5b8efbc0d01ec69e

Powered by Google App Engine
This is Rietveld 408576698