Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1217293003: Remove Material's opinion about background colours, since in fact the background colour varies dram… (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove Material's opinion about background colours, since in fact the background colour varies dramatically with the kind of material involved. Also: - give users of Material who previously relied on Material's defaults opinions about background colours - reindent stock_row.dart - import colors as colors in example/widgets/styled_text.dart, rather than in global scope, for consistency with other files - import typography as typograpyh in example/widgets/tabs.dart, rather than in global scope, for consistency with other files - make flat_button actually be transparent by not painting a background, rather than painting 0x00000000. This is the what I actually originally set out to do here. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a81bf4f2696f51c1b6ced736c2a43127f6c787c4

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
M sky/sdk/example/stocks/lib/stock_row.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sky/sdk/example/widgets/sector.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/styled_text.dart View 3 chunks +8 lines, -5 lines 0 comments Download
M sky/sdk/example/widgets/tabs.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/flat_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/material.dart View 3 chunks +1 line, -13 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 3 chunks +15 lines, -1 line 0 comments Download
M sky/tests/widgets/buttons-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-06-30 19:47:36 UTC) #2
Hixie
5 years, 5 months ago (2015-06-30 19:48:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a81bf4f2696f51c1b6ced736c2a43127f6c787c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698