Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1217243005: Gratuitous tabs example enhancement (Closed)

Created:
5 years, 5 months ago by hansmuller1
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Gratuitous tabs example enhancement Demo all three varieties of TabLabels in 3 different TabNavigators. Use another TabNavigator to select among the three Card-encapsulated demos. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7a766ca97eed510816bc9d611191dec3880605d8

Patch Set 1 #

Patch Set 2 : Updated tabs-expected.txt #

Patch Set 3 : Use new List<int> instead new List #

Patch Set 4 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -82 lines) Patch
M sky/sdk/example/widgets/tabs.dart View 1 2 3 4 chunks +64 lines, -14 lines 0 comments Download
M sky/tests/examples/tabs-expected.txt View 1 2 3 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hansmuller
PTAL
5 years, 5 months ago (2015-06-30 19:33:27 UTC) #3
abarth-chromium
lgtm
5 years, 5 months ago (2015-06-30 19:40:03 UTC) #4
hansmuller1
5 years, 5 months ago (2015-06-30 20:00:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7a766ca97eed510816bc9d611191dec3880605d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698