Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1217243003: Convert printing_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@4_url_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert printing_unittests to run exclusively on Swarming 0 configs already ran on Swarming 28 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert printing_unittests R=dpranke@chromium.org,vitalybuka@chromium.org BUG=98637 NOTRY=true Committed: https://crrev.com/350eee02c28b43a7c7f1c685d7437f09f3db613b Cr-Commit-Position: refs/heads/master@{#336859}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -2 lines) Patch
M build/gn_migration.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A + printing/printing_unittests.isolate View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 2 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (9 generated)
M-A Ruel
5 years, 5 months ago (2015-06-30 15:58:56 UTC) #1
M-A Ruel
Try jobs failed since this patch is based on another CL. I'll wait for the ...
5 years, 5 months ago (2015-06-30 16:07:16 UTC) #2
Dirk Pranke
lgtm
5 years, 5 months ago (2015-06-30 16:18:59 UTC) #3
M-A Ruel
On 2015/06/30 16:18:59, Dirk Pranke wrote: > lgtm TBR'ing to Vitaly.
5 years, 5 months ago (2015-06-30 17:58:19 UTC) #6
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 5 months ago (2015-06-30 18:03:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217243003/20001
5 years, 5 months ago (2015-06-30 18:29:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/39532)
5 years, 5 months ago (2015-06-30 19:42:14 UTC) #12
M-A Ruel
On 2015/06/30 19:42:14, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-06-30 19:45:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217243003/20001
5 years, 5 months ago (2015-06-30 19:46:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/75070)
5 years, 5 months ago (2015-06-30 19:55:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217243003/40001
5 years, 5 months ago (2015-06-30 19:58:31 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-06-30 20:05:32 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 20:06:15 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/350eee02c28b43a7c7f1c685d7437f09f3db613b
Cr-Commit-Position: refs/heads/master@{#336859}

Powered by Google App Engine
This is Rietveld 408576698