Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 121723002: [Wallpaper Picker] Fixed custom wallpaper Context Menu z-index (Closed)

Created:
6 years, 12 months ago by François Beaufort
Modified:
6 years, 9 months ago
Reviewers:
bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed custom wallpaper Context Menu z-index As you can see in `src/ui/webui/resources/css/menu.css`, the z-index CSS property for the menu is 3. Since the z-index CSS property of the check Image is also 3, it causes some UI glitches like the one below. I've set it to 2 since 1 is used by thumbnails. OLD=http://i.imgur.com/HfCtRvJ.png NOW=http://i.imgur.com/nXkLa3b.png Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
François Beaufort
Hello Biao, Just found a small UI issue in the Wallpaper Context Menu. Happy New ...
6 years, 12 months ago (2013-12-27 14:51:51 UTC) #1
bshe
On 2013/12/27 14:51:51, François Beaufort wrote: > Hello Biao, > > Just found a small ...
6 years, 11 months ago (2014-01-10 15:31:48 UTC) #2
François Beaufort
The CQ bit was checked by beaufort.francois@gmail.com
6 years, 9 months ago (2014-03-08 08:55:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/121723002/1
6 years, 9 months ago (2014-03-08 11:13:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:25:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=278198
6 years, 9 months ago (2014-03-08 13:25:34 UTC) #6
François Beaufort
The CQ bit was checked by beaufort.francois@gmail.com
6 years, 9 months ago (2014-03-10 07:45:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/121723002/1
6 years, 9 months ago (2014-03-10 07:45:20 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 12:11:10 UTC) #9
Message was sent while issue was closed.
Change committed as 255916

Powered by Google App Engine
This is Rietveld 408576698