Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217223008: [Android] Add battery status reset to device temperature check (Closed)

Created:
5 years, 5 months ago by rnephew (Reviews Here)
Modified:
5 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add battery status reset to device temperature check Makes sure battery updates are happening when checking device temperature. BUG= Committed: https://crrev.com/1c8786b2930c2a90c9c4101327d8965dcea826c2 Cr-Commit-Position: refs/heads/master@{#337171}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/android/pylib/device/battery_utils.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
rnephew (Reviews Here)
5 years, 5 months ago (2015-07-01 23:19:24 UTC) #2
jbudorick
https://codereview.chromium.org/1217223008/diff/1/build/android/pylib/device/battery_utils.py File build/android/pylib/device/battery_utils.py (right): https://codereview.chromium.org/1217223008/diff/1/build/android/pylib/device/battery_utils.py#newcode458 build/android/pylib/device/battery_utils.py:458: self._device.RunShellCommand( EnableBatteryUpdates? Also, if battery updates are disabled coming ...
5 years, 5 months ago (2015-07-01 23:23:32 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/1217223008/diff/1/build/android/pylib/device/battery_utils.py File build/android/pylib/device/battery_utils.py (right): https://codereview.chromium.org/1217223008/diff/1/build/android/pylib/device/battery_utils.py#newcode458 build/android/pylib/device/battery_utils.py:458: self._device.RunShellCommand( On 2015/07/01 23:23:32, jbudorick (ooo until july 13) ...
5 years, 5 months ago (2015-07-01 23:28:42 UTC) #4
jbudorick
lgtm
5 years, 5 months ago (2015-07-01 23:30:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217223008/20001
5 years, 5 months ago (2015-07-01 23:32:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/40240)
5 years, 5 months ago (2015-07-02 01:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217223008/20001
5 years, 5 months ago (2015-07-02 01:56:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-02 04:16:06 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 04:17:10 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c8786b2930c2a90c9c4101327d8965dcea826c2
Cr-Commit-Position: refs/heads/master@{#337171}

Powered by Google App Engine
This is Rietveld 408576698