Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 1217173003: [Release tools] Add instructions how to close the auto-roller. (Closed)

Created:
5 years, 5 months ago by Michael Hablich
Modified:
5 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Release tools] Add instructions how to close the auto-roller. R=machenbach@chromium.org BUG=chromium:494641 LOG=N NOTRY=true Committed: https://crrev.com/a023b39f351f1f96a075e63c647a7a40e93ddb5e Cr-Commit-Position: refs/heads/master@{#29404}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Required changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/release/chromium_roll.py View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Michael Hablich
PTAL
5 years, 5 months ago (2015-06-30 14:13:44 UTC) #1
Michael Achenbach
lg nit: Shorten commit message and make it say what the CL does not what ...
5 years, 5 months ago (2015-07-01 05:39:56 UTC) #2
Michael Hablich
https://codereview.chromium.org/1217173003/diff/1/tools/release/chromium_roll.py File tools/release/chromium_roll.py (right): https://codereview.chromium.org/1217173003/diff/1/tools/release/chromium_roll.py#newcode17 tools/release/chromium_roll.py:17: https://code.google.com/p/v8-wiki/wiki/TriagingIssues/n On 2015/07/01 05:39:56, Michael Achenbach wrote: > Remove ...
5 years, 5 months ago (2015-07-01 09:13:31 UTC) #3
Michael Achenbach
LGTM. Small rietveld gotcha: The CL description exists two times - you changed the right ...
5 years, 5 months ago (2015-07-01 09:33:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217173003/20001
5 years, 5 months ago (2015-07-01 09:35:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-01 09:37:06 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a023b39f351f1f96a075e63c647a7a40e93ddb5e Cr-Commit-Position: refs/heads/master@{#29404}
5 years, 5 months ago (2015-07-01 09:37:30 UTC) #8
Michael Achenbach
Next gotcha: bugdroid works only cross-repo if the bug is prefixed. E.g. chromium issues in ...
5 years, 5 months ago (2015-07-01 09:51:26 UTC) #9
Michael Hablich
5 years, 5 months ago (2015-07-01 09:54:52 UTC) #10
Message was sent while issue was closed.
On 2015/07/01 09:51:26, Michael Achenbach wrote:
> Next gotcha: bugdroid works only cross-repo if the bug is prefixed. E.g.
> chromium issues in v8 CLs need BUG=chromium:494641

Ha, I thought the Chromium repo is the default as Rietveld is correctly
displaying it.

Powered by Google App Engine
This is Rietveld 408576698