chrome/common/extensions/docs/templates/private/ref_link.html - Issue 121713002: Rework API reference pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/ref_link.html

Issue 121713002: Rework API reference pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@addscss_330235

Patch Set: moved inline style to sass file Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <a href="{{link.href}}">{{link.text}}</a>	1 {{^no_link}}<a href="{{link.href}}">{{/}}
	not at google - send to devlin 2014/01/03 23:30:24 given that no_link is only passed in from one plac given that no_link is only passed in from one place (variable_type.html) you could do there {{?disableLink}} {{link.text}} {{:disableLink}} {{+partials.ref_link link:link/}} {{/disableLink}} and not need to pass it in here; since passing "no link" into a file called "... link" looks a bit weird. Renato Mangini (chromium) 2014/02/06 03:19:17 Done. Show quoted text On 2014/01/03 23:30:24, kalman - OOO wrote: > given that no_link is only passed in from one place (variable_type.html) you > could do there > > {{?disableLink}} > {{link.text}} > {{:disableLink}} > {{+partials.ref_link link:link/}} > {{/disableLink}} > > and not need to pass it in here; since passing "no link" into a file called "... > link" looks a bit weird. Done.
	2 {{link.text}}

	3 {{^no_link}}</a>{{/}}

OLD	NEW