chrome/common/extensions/docs/templates/private/callback.html - Issue 121713002: Rework API reference pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/callback.html

Issue 121713002: Rework API reference pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@addscss_330235

Patch Set: moved inline style to sass file Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/templates/private/api_summary.html ('K') | « chrome/common/extensions/docs/templates/private/api_summary.html ('k') | chrome/common/extensions/docs/templates/private/function.html » ('j') | chrome/common/extensions/docs/templates/private/function.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {{#callback}}	1 {{#callback}}

2 <p>

3 {{?optional}}	2 {{?optional}}

4 If you specify the <em>{{name}}</em> parameter, it should	3 If you specify the <em>{{name}}</em> parameter, it should

5 specify a function that looks like this:	4 specify a function that looks like this:

6 {{:optional}}	5 {{:optional}}

7 The <em>{{name}}</em> parameter should specify a function	6 The <em>{{name}}</em> parameter should specify a function

8 that looks like this:	7 that looks like this:

9 {{/optional}}	8 {{/optional}}

10 </p>	9 <br/>
	not at google - send to devlin 2014/01/03 23:30:24 prefer to separate blocks via block elements rathe prefer to separate blocks via block elements rather than <br> if possible. the <code> block seems semantically separate from the text above. Renato Mangini (chromium) 2014/02/06 03:19:17 Done. Show quoted text On 2014/01/03 23:30:24, kalman - OOO wrote: > prefer to separate blocks via block elements rather than <br> if possible. the > <code> block seems semantically separate from the text above. Done.
11 <pre>function({{#p:parameters}}{{+partials.variable_type type:p/}} {{p.name}}{{^ p.last}}, {{/}}{{/}}) <span class="subdued">{...}</span>;</pre>	10 <code class="prettyprint">function({{#p:parameters}}{{+partials.variable_type ty pe:p/}} {{p.name}}{{^p.last}}, {{/}}{{/}}) <span class="subdued">{...}</span>;</ code>

12 {{?description}}	11 {{?description}}

13 <p>	12 <p>

14 {{{description}}}	13 {{{description}}}

15 </p>	14 </p>

16 {{/description}}	15 {{/description}}

17 {{?parameters}}	16 {{?parameters}}

18 <dl>	17 <table class="innerTable">

19 {{#p:parameters}}	18 {{#p:parameters}}

20 {{+partials.parameter_full parameter:p parentName:name hideParamTOC:true /}}	19 {{+partials.parameter_full parameter:p parentName:name hideParamTOC:true /}}

21 {{/parameters}}	20 {{/parameters}}

22 </dl>	21 </table>

23 {{/parameters}}	22 {{/parameters}}

24 {{/callback}}	23 {{/callback}}

OLD	NEW