chrome/common/extensions/docs/templates/private/api_property.html - Issue 121713002: Rework API reference pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/api_property.html

Issue 121713002: Rework API reference pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@addscss_330235

Patch Set: moved inline style to sass file Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/static/sass/_api.scss ('K') | « chrome/common/extensions/docs/templates/private/api.html ('k') | chrome/common/extensions/docs/templates/private/api_reference.html » ('j') | chrome/common/extensions/docs/templates/private/api_summary.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {{#property}}	1 {{#property}}

2 <div>	2 <tr>

3 <h3 id="{{id}}">{{name}}</h3>	3 <td>{{+partials.type_name link:link type:property/}}</td>

4 <div class="summary">	4 <td><code id="{{id}}">{{api.namespace}}.{{name}}</code></td>

5 <div class="line">{{api.namespace}}.{{name}}</div>	5 <td>

6 </div>	6 {{?description}}

7 <div>

8 <dt><span class="property">{{name}}</span> {{+partials.type_name link:link t ype:property/}}</dt>

9 {{?description}}<dd>

10 {{{description}}}	7 {{{description}}}

11 </dd>{{/description}}	8 {{/description}}

12 {{?properties}}	9 {{?properties}}

13 <h4 id="{{name}}-properties" title="">	10 <table class="innerTable">
	not at google - send to devlin 2014/01/03 23:30:24 what is "innerTable" supposed to be? I see it used what is "innerTable" supposed to be? I see it used a bunch but it's not clear from context why it should be "inner". is there a semantically meaningful name it could be? Renato Mangini (chromium) 2014/02/06 03:19:17 It is a table that is inside another, and thus has It is a table that is inside another, and thus has slightly different CSS properties (mostly margins and padding). On 2014/01/03 23:30:24, kalman - OOO wrote: Show quoted text > what is "innerTable" supposed to be? I see it used a bunch but it's not clear > from context why it should be "inner". is there a semantically meaningful name > it could be?
14 Properties of <a href="#property-{{name}}">{{name}}</a>	11 <thead><th colspan="3">Properties</th></thead>

15 </h4>	12 {{#p:properties}}

16 <dd><dl>{{#p:properties}}

17 {{+partials.parameter_full parameter:p parentName:false/}}	13 {{+partials.parameter_full parameter:p parentName:false/}}

18 {{/properties}}</dl></dd>	14 {{/properties}}

	15 </table>

19 {{/properties}}	16 {{/properties}}

20 {{?functions}}	17 {{?functions}}

21 <h4 id="{{name}}-functions" title="">	18 <table class="innerTable">

22 Methods of <a href="#property-{{name}}">{{name}}</a>	19 <thead><th colspan="3">Functions</th></thead>

23 </h4>	20 {{#f:functions}}

24 <dd><dl>{{#f:functions}}

25 {{+partials.function function:f parentName:false/}}	21 {{+partials.function function:f parentName:false/}}

26 {{/}}</dl></dd>

27 {{/functions}}	22 {{/functions}}

28 </div>	23 </table>

29 </div>	24 {{/functions}}

	25 </td>

	26 </tr>

30 {{/property}}	27 {{/property}}

OLD	NEW