Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1217123004: Remove usage of to-be-deprecated APIs from tools (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove usage of to-be-deprecated APIs from tools BUG=v8:4134 R=bmeurer@chromium.org LOG=n Committed: https://crrev.com/da529a124333165bd060360f4b59e141b749a319 Cr-Commit-Position: refs/heads/master@{#29474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M tools/parser-shell.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M tools/parser-shell.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-06 06:31:22 UTC) #1
Benedikt Meurer
LGTM (rubber-stamped)
5 years, 5 months ago (2015-07-06 06:43:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217123004/1
5 years, 5 months ago (2015-07-06 06:45:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 07:11:45 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 07:12:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da529a124333165bd060360f4b59e141b749a319
Cr-Commit-Position: refs/heads/master@{#29474}

Powered by Google App Engine
This is Rietveld 408576698