Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1217093007: Add a //nogncheck anntation to GN include checker (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a //nogncheck anntation to GN include checker The include checker will now skip includes annotated with "// nogncheck" which allows some edge cases to be worked around while still running the check pass on the rest of the includes. This also updates the reference docs to the latest version. Committed: https://crrev.com/20982dc0654c13678837bdb4c08e1bcc94248fcf Cr-Commit-Position: refs/heads/master@{#337499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -2 lines) Patch
M tools/gn/c_include_iterator.cc View 2 chunks +6 lines, -1 line 0 comments Download
M tools/gn/c_include_iterator_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M tools/gn/docs/reference.md View 9 chunks +115 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 5 months ago (2015-07-06 21:59:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217093007/1
5 years, 5 months ago (2015-07-06 21:59:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-06 22:15:08 UTC) #6
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-06 22:24:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217093007/1
5 years, 5 months ago (2015-07-06 22:28:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 22:37:15 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 22:38:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20982dc0654c13678837bdb4c08e1bcc94248fcf
Cr-Commit-Position: refs/heads/master@{#337499}

Powered by Google App Engine
This is Rietveld 408576698