Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1217093005: Refactor stateful parts of Component into StatefulComponent (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweak README copy #

Patch Set 3 : Fix analyzer warning and add assert #

Patch Set 4 : add missing parameter #

Patch Set 5 : fix another use of inherit #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : remove an assert that turns out not to be true #

Patch Set 10 : rebase #

Patch Set 11 : move scheduleBuild #

Patch Set 12 : Remove access to _stateful that should not be there #

Patch Set 13 : only sync with stateful components #

Patch Set 14 : rebase #

Patch Set 15 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -83 lines) Patch
M sky/sdk/example/mine_digger/lib/main.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_home.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_settings.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/editing/editable_text.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/editing/input.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/README.md View 1 2 chunks +3 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/button_base.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/navigator.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 8 chunks +68 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackson
5 years, 5 months ago (2015-07-06 16:10:35 UTC) #1
eseidel
Hmmm. So this would mean then that you can't subclass a non-stateful component add make ...
5 years, 5 months ago (2015-07-06 16:15:10 UTC) #3
abarth-chromium
On 2015/07/06 at 16:15:10, eseidel wrote: > Hmmm. So this would mean then that you ...
5 years, 5 months ago (2015-07-06 16:15:46 UTC) #4
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-06 16:17:16 UTC) #6
jackson
5 years, 5 months ago (2015-07-07 00:09:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #15 (id:280001) manually as
2bbff5e52dee4a9dc4fdd98709f1b01ea04fd8ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698