Index: src/x87/builtins-x87.cc |
diff --git a/src/x87/builtins-x87.cc b/src/x87/builtins-x87.cc |
index 311290ff2f96a7e10f266458fbb6b696b324d942..7c4852508021e9f2736fdda8cb5eb3f0ff958dc0 100644 |
--- a/src/x87/builtins-x87.cc |
+++ b/src/x87/builtins-x87.cc |
@@ -138,6 +138,7 @@ static void Generate_Runtime_NewObject(MacroAssembler* masm, |
static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
bool is_api_function, |
+ bool use_new_target, |
bool create_memento) { |
// ----------- S t a t e ------------- |
// -- eax: number of arguments |
@@ -158,12 +159,13 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
__ push(ebx); |
} |
- // Store a smi-tagged arguments count on the stack. |
+ // Preserve the incoming parameters on the stack. |
__ SmiTag(eax); |
__ push(eax); |
- |
- // Push the function to invoke on the stack. |
__ push(edi); |
+ if (use_new_target) { |
+ __ push(edx); |
+ } |
__ cmp(edx, edi); |
Label normal_new; |
@@ -399,7 +401,8 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
__ bind(&allocated); |
if (create_memento) { |
- __ mov(ecx, Operand(esp, kPointerSize * 2)); |
+ int offset = (use_new_target ? 3 : 2) * kPointerSize; |
+ __ mov(ecx, Operand(esp, offset)); |
__ cmp(ecx, masm->isolate()->factory()->undefined_value()); |
__ j(equal, &count_incremented); |
// ecx is an AllocationSite. We are creating a memento from it, so we |
@@ -409,13 +412,22 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
__ bind(&count_incremented); |
} |
- // Retrieve the function from the stack. |
- __ pop(edi); |
+ // Restore the parameters. |
+ if (use_new_target) { |
+ __ pop(edx); // new.target |
+ } |
+ __ pop(edi); // Constructor function. |
// Retrieve smi-tagged arguments count from the stack. |
__ mov(eax, Operand(esp, 0)); |
__ SmiUntag(eax); |
+ // Push new.target onto the construct frame. This is stored just below the |
+ // receiver on the stack. |
+ if (use_new_target) { |
+ __ push(edx); |
+ } |
+ |
// Push the allocated receiver to the stack. We need two copies |
// because we may have to return the original one and the calling |
// conventions dictate that the called function pops the receiver. |
@@ -448,7 +460,9 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
} |
// Store offset of return address for deoptimizer. |
- if (!is_api_function) { |
+ // TODO(arv): Remove the "!use_new_target" before supporting optimization |
+ // of functions that reference new.target |
+ if (!is_api_function && !use_new_target) { |
masm->isolate()->heap()->SetConstructStubDeoptPCOffset(masm->pc_offset()); |
} |
@@ -473,9 +487,11 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
__ bind(&use_receiver); |
__ mov(eax, Operand(esp, 0)); |
- // Restore the arguments count and leave the construct frame. |
+ // Restore the arguments count and leave the construct frame. The arguments |
+ // count is stored below the reciever and the new.target. |
__ bind(&exit); |
- __ mov(ebx, Operand(esp, kPointerSize)); // Get arguments count. |
+ int offset = (use_new_target ? 2 : 1) * kPointerSize; |
+ __ mov(ebx, Operand(esp, offset)); |
// Leave construct frame. |
} |
@@ -491,12 +507,17 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
void Builtins::Generate_JSConstructStubGeneric(MacroAssembler* masm) { |
- Generate_JSConstructStubHelper(masm, false, FLAG_pretenuring_call_new); |
+ Generate_JSConstructStubHelper(masm, false, false, FLAG_pretenuring_call_new); |
} |
void Builtins::Generate_JSConstructStubApi(MacroAssembler* masm) { |
- Generate_JSConstructStubHelper(masm, true, false); |
+ Generate_JSConstructStubHelper(masm, true, false, false); |
+} |
+ |
+ |
+void Builtins::Generate_JSConstructStubNewTarget(MacroAssembler* masm) { |
+ Generate_JSConstructStubHelper(masm, false, true, FLAG_pretenuring_call_new); |
} |