Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1217083004: X87: [es6] Make new.target work in functions. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Make new.target work in functions. port 7a63bf77eb7610afdc1a968f7660781e5160ba8d (r29358). original commit message: This makes new.target work in [[Call]] and [[Construct]] of ordinary functions. We achieve this by introducing a new construct stub for functions that uses the new.target variable. The construct stub pushes the original constructor just above the receiver in the construct frame. BUG= Committed: https://crrev.com/b913e2a97ad9b268751d709de9107d4a409d9280 Cr-Commit-Position: refs/heads/master@{#29413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M src/x87/builtins-x87.cc View 7 chunks +32 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-06-30 09:20:57 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 11:05:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217083004/1
5 years, 5 months ago (2015-07-01 11:05:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 12:05:22 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 12:05:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b913e2a97ad9b268751d709de9107d4a409d9280
Cr-Commit-Position: refs/heads/master@{#29413}

Powered by Google App Engine
This is Rietveld 408576698