Edges matter, part 2.

src/core/Sk4pxXfermode.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef Sk4pxXfermode_DEFINED
 #define Sk4pxXfermode_DEFINED
 
@@ skipping 50 matching lines @@
     // There's no chance of underflow, and if we subtract p before adding src+dst, no overflow.
     return (s - p) + (d - p.zeroAlphas());
 }
 
 XFERMODE(HardLight) {
     auto alphas = SrcOver::Xfer(s,d);
 
     auto sa = s.alphas(),
          da = d.alphas();
 
-    auto isDark = s < (sa-s);
+    auto isLite = (sa-s) < s;
 
     auto dark = s*d << 1,
          lite = sa*da - ((da-d)*(sa-s) << 1),
          both = s*da.inv() + d*sa.inv();
 
-    // TODO: do isDark in 16-bit so we only have to div255() once.
-    auto colors = isDark.thenElse((dark + both).div255(),
-                                  (lite + both).div255());
+    // TODO: do isLite in 16-bit so we only have to div255() once.
+    auto colors = isLite.thenElse((lite + both).div255(),
+                                  (dark + both).div255());
     return alphas.zeroColors() + colors.zeroAlphas();
 }
 XFERMODE(Overlay) { return HardLight::Xfer(d,s); }
 
 XFERMODE(Darken) {
     auto sda = s.approxMulDiv255(d.alphas()),
          dsa = d.approxMulDiv255(s.alphas());
     auto srcover = s + (d - dsa),
          dstover = d + (s - sda);
     auto alphas = srcover,
          colors = (sda < dsa).thenElse(srcover, dstover);
     return alphas.zeroColors() + colors.zeroAlphas();
 }
 XFERMODE(Lighten) {
     auto sda = s.approxMulDiv255(d.alphas()),
          dsa = d.approxMulDiv255(s.alphas());
     auto srcover = s + (d - dsa),
          dstover = d + (s - sda);
     auto alphas = srcover,
-         colors = (sda < dsa).thenElse(dstover, srcover);
+         colors = (dsa < sda).thenElse(srcover, dstover);
     return alphas.zeroColors() + colors.zeroAlphas();
 }
 #undef XFERMODE
 
 // Some xfermodes use math like divide or sqrt that's best done in floats 1 pixel at a time.
 #define XFERMODE(Name) \
     struct Name {                                                         \
         static SkPMFloat Xfer(const SkPMFloat&, const SkPMFloat&);        \
         static const SkXfermode::Mode kMode = SkXfermode::k##Name##_Mode; \
     };                                                                    \
@@ skipping 137 matching lines @@
 #endif
         default: break;
     }
 #endif
     return nullptr;
 }
 
 } // namespace
 
 #endif//Sk4pxXfermode_DEFINED