Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1216983004: clang/win: Build with some more clang warnings enabled. (Closed)

Created:
5 years, 5 months ago by Sam McNally
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clang-missing-declarations
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Build with some more clang warnings enabled. This removes -Wno-deprecated-declarations, -Wno-enum-conversions and -Wno-return-type-c-linkage. BUG=504660, 505305, 504662 Committed: https://crrev.com/8cd95c04a3cf810b638862e2db8fdbcc453d4f7f Cr-Commit-Position: refs/heads/master@{#337017}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/common.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
5 years, 5 months ago (2015-07-01 07:58:58 UTC) #3
Nico
lgtm
5 years, 5 months ago (2015-07-01 13:29:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216983004/40001
5 years, 5 months ago (2015-07-01 14:03:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-07-01 14:06:45 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 14:07:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cd95c04a3cf810b638862e2db8fdbcc453d4f7f
Cr-Commit-Position: refs/heads/master@{#337017}

Powered by Google App Engine
This is Rietveld 408576698