Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1216973005: Turn off the code that is forcing stocksapp to build 50 times a second, and change the code that tr… (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Turn off the code that is forcing stocksapp to build 50 times a second, and change the code that tracks frame times to be a bit cleverer. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/812dfd4c124f68bc6e49924a18e0f0119f63d5c9

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M sky/sdk/example/stocks/lib/main.dart View 1 chunk +1 line, -1 line 1 comment Download
M sky/sdk/lib/widgets/widget.dart View 2 chunks +9 lines, -1 line 1 comment Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1216973005/diff/1/sky/sdk/example/stocks/lib/main.dart File sky/sdk/example/stocks/lib/main.dart (right): https://codereview.chromium.org/1216973005/diff/1/sky/sdk/example/stocks/lib/main.dart#newcode89 sky/sdk/example/stocks/lib/main.dart:89: runApp(new StocksApp(), enableProfilingLoop: false); Can we delete the ...
5 years, 5 months ago (2015-06-29 22:39:58 UTC) #2
Hixie
5 years, 5 months ago (2015-06-29 22:42:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
812dfd4c124f68bc6e49924a18e0f0119f63d5c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698