Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1216963014: Add a leak sanitizer suppression for ResourceFetcher (Closed)

Created:
5 years, 5 months ago by peria
Modified:
5 years, 5 months ago
Reviewers:
haraken, oilpan-reviews
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a leak sanitizer suppression for blink::ResourceFetcher::garbageCollectDocumentResources In content_browsertests, LSAN reports the leak happens in ResourceFetcher, but its (persistent|ref) pointer is held by a live instance of Document or DocumentLoader at the end of the tests. BUG=506433 Committed: https://crrev.com/2af3041652d3a473995babb42e0d71778427dfdf Cr-Commit-Position: refs/heads/master@{#337371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/sanitizers/lsan_suppressions.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
peria
Investigating of http://crrev.com/1124153003/, we think the leak is not caused by the CL. https://codereview.chromium.org/1124153003/#msg35 It ...
5 years, 5 months ago (2015-07-06 07:57:14 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-06 07:58:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216963014/1
5 years, 5 months ago (2015-07-06 07:59:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 08:33:33 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 08:34:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2af3041652d3a473995babb42e0d71778427dfdf
Cr-Commit-Position: refs/heads/master@{#337371}

Powered by Google App Engine
This is Rietveld 408576698