Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: src/IceIntrinsics.h

Issue 1216963007: Doxygenize the documentation comments (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceIntrinsics.h
diff --git a/src/IceIntrinsics.h b/src/IceIntrinsics.h
index 938243f2293e2dadecaa67b9d6c6a6606dab713f..4a66dd884f4637e74802abd8961f7332c160b230 100644
--- a/src/IceIntrinsics.h
+++ b/src/IceIntrinsics.h
@@ -31,9 +31,9 @@ public:
Intrinsics();
~Intrinsics();
- // Some intrinsics allow overloading by type. This enum collapses all
- // overloads into a single ID, but the type can still be recovered by the
- // type of the intrinsic function call's return value and parameters.
+ /// Some intrinsics allow overloading by type. This enum collapses all
+ /// overloads into a single ID, but the type can still be recovered by the
+ /// type of the intrinsic function call's return value and parameters.
enum IntrinsicID {
UnknownIntrinsic = 0,
// Arbitrary (alphabetical) order.
@@ -92,9 +92,9 @@ public:
MemoryOrderNum // Invalid, keep last.
};
- // Verify memory ordering rules for atomic intrinsics. For
- // AtomicCmpxchg, Order is the "success" ordering and OrderOther is
- // the "failure" ordering. Returns true if valid, false if invalid.
+ /// Verify memory ordering rules for atomic intrinsics. For
+ /// AtomicCmpxchg, Order is the "success" ordering and OrderOther is
+ /// the "failure" ordering. Returns true if valid, false if invalid.
// TODO(stichnot,kschimpf): Perform memory order validation in the
// bitcode reader/parser, allowing LLVM and Subzero to share. See
// https://code.google.com/p/nativeclient/issues/detail?id=4126 .
@@ -115,7 +115,7 @@ public:
enum ReturnsTwice ReturnsTwice : 1;
};
- // The types of validation values for FullIntrinsicInfo.validateCall.
+ /// The types of validation values for FullIntrinsicInfo.validateCall.
enum ValidateCallValue {
IsValidCall, // Valid use of instrinsic call.
Karl 2015/07/06 18:08:48 Maybe add /// here to? These comments appear to be
ascull 2015/07/06 19:29:09 Done.
BadReturnType, // Return type invalid for intrinsic.
@@ -123,43 +123,43 @@ public:
WrongCallArgType, // Argument of wrong type.
};
- // The complete set of information about an intrinsic.
+ /// The complete set of information about an intrinsic.
struct FullIntrinsicInfo {
- struct IntrinsicInfo Info; // Information that CodeGen would care about.
+ struct IntrinsicInfo Info; /// Information that CodeGen would care about.
// Sanity check during parsing.
Type Signature[kMaxIntrinsicParameters];
uint8_t NumTypes;
- // Validates that type signature of call matches intrinsic.
- // If WrongArgumentType is returned, ArgIndex is set to corresponding
- // argument index.
+ /// Validates that type signature of call matches intrinsic.
+ /// If WrongArgumentType is returned, ArgIndex is set to corresponding
+ /// argument index.
ValidateCallValue validateCall(const Ice::InstCall *Call,
SizeT &ArgIndex) const;
- // Returns the return type of the intrinsic.
+ /// Returns the return type of the intrinsic.
Type getReturnType() const {
assert(NumTypes > 1);
return Signature[0];
}
- // Returns number of arguments expected.
+ /// Returns number of arguments expected.
SizeT getNumArgs() const {
assert(NumTypes > 1);
return NumTypes - 1;
}
- // Returns type of Index-th argument.
+ /// Returns type of Index-th argument.
Type getArgType(SizeT Index) const;
};
- // Find the information about a given intrinsic, based on function name. If
- // the function name does not have the common "llvm." prefix, nullptr is
- // returned and Error is set to false. Otherwise, tries to find a reference
- // to a FullIntrinsicInfo entry (valid for the lifetime of the map). If
- // found, sets Error to false and returns the reference. If not found, sets
- // Error to true and returns nullptr (indicating an unknown "llvm.foo"
- // intrinsic).
+ /// Find the information about a given intrinsic, based on function name. If
+ /// the function name does not have the common "llvm." prefix, nullptr is
+ /// returned and Error is set to false. Otherwise, tries to find a reference
+ /// to a FullIntrinsicInfo entry (valid for the lifetime of the map). If
+ /// found, sets Error to false and returns the reference. If not found, sets
+ /// Error to true and returns nullptr (indicating an unknown "llvm.foo"
+ /// intrinsic).
const FullIntrinsicInfo *find(const IceString &Name, bool &Error) const;
private:

Powered by Google App Engine
This is Rietveld 408576698