Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1216953003: Promote scrollTopLeftInterop mode to experimental (Closed)

Created:
5 years, 5 months ago by Rick Byers
Modified:
5 years, 4 months ago
Reviewers:
tdresser
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Promote scrollTopLeftInterop mode to experimental We're about ready to try making this behavior 'stable'. To help flush out issues in advance of that, promote it to 'experimental'. BUG=157855 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200602

Patch Set 1 #

Patch Set 2 : Cleanup a couple more tests #

Patch Set 3 : Merge with trunk #

Patch Set 4 : Fix failing WebViewTest.PreferredSize #

Patch Set 5 : Remove fixes moved to other patches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -41 lines) Patch
M LayoutTests/fast/dom/Document/scrollingElement-noLayout-quirks.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Document/scrollingElement-noStyleUpdate-strict.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-body.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-frameset.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-frameset-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Element/scrollingElement-null-body-documentElement.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scroll-in-standards-mode.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scroll-in-standards-mode-expected.txt View 2 chunks +19 lines, -19 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Rick Byers
Tim, PTAL There are two test failures I'll fix in other patches first (in case ...
5 years, 4 months ago (2015-08-13 02:05:30 UTC) #2
tdresser
LGTM!
5 years, 4 months ago (2015-08-13 13:48:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216953003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1216953003/80001
5 years, 4 months ago (2015-08-14 14:43:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93293)
5 years, 4 months ago (2015-08-14 16:48:47 UTC) #7
Rick Byers
On 2015/08/14 16:48:47, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 4 months ago (2015-08-14 20:10:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216953003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1216953003/80001
5 years, 4 months ago (2015-08-14 21:06:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93581)
5 years, 4 months ago (2015-08-14 22:24:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216953003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1216953003/80001
5 years, 4 months ago (2015-08-15 04:51:27 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 06:44:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200602

Powered by Google App Engine
This is Rietveld 408576698