ui/gfx/android/view_configuration.h - Issue 1216933013: [Android] Expose native ViewConfiguration constants as DIPs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/android/view_configuration.h

Issue 1216933013: [Android] Expose native ViewConfiguration constants as DIPs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment and add assert Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/android/view_configuration.h

diff --git a/ui/gfx/android/view_configuration.h b/ui/gfx/android/view_configuration.h

index 4595071c4f1c7176d1009eb02c4e9fef0b972f65..1c490c9a5037956007c49b987a0d4dc71120611c 100644

--- a/ui/gfx/android/view_configuration.h

+++ b/ui/gfx/android/view_configuration.h

@@ -22,14 +22,14 @@ class GFX_EXPORT ViewConfiguration {

// Dimensionless coefficient of friction.

static float GetScrollFriction();

- static int GetMaximumFlingVelocityInPixelsPerSecond();

- static int GetMinimumFlingVelocityInPixelsPerSecond();

+ static int GetMaximumFlingVelocityInDipsPerSecond();

+ static int GetMinimumFlingVelocityInDipsPerSecond();

- static int GetTouchSlopInPixels();

- static int GetDoubleTapSlopInPixels();

+ static int GetTouchSlopInDips();

+ static int GetDoubleTapSlopInDips();

- static int GetMinScalingSpanInPixels();

- static int GetMinScalingTouchMajorInPixels();

+ static int GetMinScalingSpanInDips();

+ static int GetMinScalingTouchMajorInDips();

// Registers methods with JNI and returns true if succeeded.

static bool RegisterViewConfiguration(JNIEnv* env);

« no previous file with comments | « ui/events/gesture_detection/gesture_configuration_android.cc ('k') | ui/gfx/android/view_configuration.cc » ('j') | no next file with comments »