content/browser/renderer_host/render_widget_host_view_android.cc - Issue 1216933013: [Android] Expose native ViewConfiguration constants as DIPs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 1216933013: [Android] Expose native ViewConfiguration constants as DIPs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment and add assert Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/synthetic_gesture_target_android.cc ('k') | ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index f1b29bf932cbf063ad3e0d123cb0724c30a36859..0c86ebdbcfad4c3486a594831ebf0bbfdbe2dacd 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -272,8 +272,7 @@ scoped_ptr<ui::TouchSelectionController> CreateSelectionController(

ui::TouchSelectionController::Config config;

config.tap_timeout = base::TimeDelta::FromMilliseconds(

gfx::ViewConfiguration::GetTapTimeoutInMs());

- config.tap_slop = gfx::ViewConfiguration::GetTouchSlopInPixels() /

- content_view_core->GetDpiScale();

+ config.tap_slop = gfx::ViewConfiguration::GetTouchSlopInDips();

config.show_on_tap_for_empty_editable = false;

config.enable_longpress_drag_selection =

base::CommandLine::ForCurrentProcess()->HasSwitch(