Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: LayoutTests/fast/js/resources/select-options-remove.js

Issue 1216933002: HTMLOptionsCollection remove() argument should be long, not unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/js/select-options-remove-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/js/resources/select-options-remove.js
diff --git a/LayoutTests/fast/js/resources/select-options-remove.js b/LayoutTests/fast/js/resources/select-options-remove.js
index 61c0d7c187d1aaff07a034da7b9f4ced45b33af3..b64b60577adc758b9d26d16c3145c2e28387b81d 100644
--- a/LayoutTests/fast/js/resources/select-options-remove.js
+++ b/LayoutTests/fast/js/resources/select-options-remove.js
@@ -240,3 +240,27 @@ shouldNotBe("select2.parentNode", "null");
shouldBe("select2.remove()", "undefined");
shouldBeNull("select2.parentNode");
debug("");
+
+debug("2.18 Remove index -2147483649 from non-empty Options");
+shouldBe("select2.options.remove(-2147483649)", "undefined");
philipj_slow 2015/06/29 09:33:05 Checking the return value of remove() doesn't seem
shiva.jm 2015/06/30 05:33:23 Done.
+debug("");
+
+debug("2.19 Remove index -2147483648 from non-empty Options");
+shouldBe("select2.options.remove(-2147483648)", "undefined");
+debug("");
+
+debug("2.20 Remove index -2147483647 from non-empty Options");
+shouldBe("select2.options.remove(-2147483647)", "undefined");
+debug("");
+
+debug("2.21 Remove index 2147483649 from non-empty Options");
+shouldBe("select2.options.remove(2147483649)", "undefined");
+debug("");
+
+debug("2.22 Remove index 2147483648 from non-empty Options");
+shouldBe("select2.options.remove(2147483648)", "undefined");
+debug("");
+
+debug("2.23 Remove index 2147483647 from non-empty Options");
+shouldBe("select2.options.remove(2147483647)", "undefined");
+debug("");
« no previous file with comments | « no previous file | LayoutTests/fast/js/select-options-remove-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698