Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: Source/core/html/HTMLOptionsCollection.idl

Issue 1216933002: HTMLOptionsCollection remove() argument should be long, not unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * Copyright (C) 2013, 2014 Samsung Electronics. All rights reserved. 4 * Copyright (C) 2013, 2014 Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 12 matching lines...) Expand all
23 23
24 [ 24 [
25 DependentLifetime, 25 DependentLifetime,
26 SetWrapperReferenceFrom=ownerNode, 26 SetWrapperReferenceFrom=ownerNode,
27 ] interface HTMLOptionsCollection : HTMLCollection { 27 ] interface HTMLOptionsCollection : HTMLCollection {
28 // inherits item() 28 // inherits item()
29 [Custom=Setter, RaisesException=Setter] attribute unsigned long length; // s hadows inherited length 29 [Custom=Setter, RaisesException=Setter] attribute unsigned long length; // s hadows inherited length
30 // FIXME: The spec has a legacycaller HTMLOptionElement? (DOMString name); 30 // FIXME: The spec has a legacycaller HTMLOptionElement? (DOMString name);
31 [RaisesException, TypeChecking=Interface] setter void (unsigned long index, HTMLOptionElement? option); 31 [RaisesException, TypeChecking=Interface] setter void (unsigned long index, HTMLOptionElement? option);
32 [RaisesException, TypeChecking=Interface] void add((HTMLOptionElement or HTM LOptGroupElement) element, optional (HTMLElement or long)? before = null); 32 [RaisesException, TypeChecking=Interface] void add((HTMLOptionElement or HTM LOptGroupElement) element, optional (HTMLElement or long)? before = null);
33 // FIXME: the index argument should be long, not unsigned long. 33 void remove(long index);
34 void remove(unsigned long index);
35 attribute long selectedIndex; 34 attribute long selectedIndex;
36 // FIXME: Neither of these getters are in the spec, and the 35 // FIXME: Neither of these getters are in the spec, and the
37 // getters inherited from HTMLCollection always return an Element. 36 // getters inherited from HTMLCollection always return an Element.
38 [ImplementedAs=item] getter Node (unsigned long index); 37 [ImplementedAs=item] getter Node (unsigned long index);
39 [ImplementedAs=namedGetter] getter (NodeList or Element)? namedItem(DOMStrin g name); 38 [ImplementedAs=namedGetter] getter (NodeList or Element)? namedItem(DOMStrin g name);
40 }; 39 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698