Issue 1216923008: Fix test failures from my previous animation patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216923008: Fix test failures from my previous animation patch. (Closed)

Created:
5 years, 5 months ago by Matt Perry

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix test failures from my previous animation patch. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d31b9084a537e1474756ed54deb06f23e066168d

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	sky/sdk/lib/widgets/material.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/tests/examples/sector-expected.txt	View		6 chunks	+6 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Matt Perry

https://codereview.chromium.org/1216923008/diff/1/sky/tests/examples/sector-expected.txt File sky/tests/examples/sector-expected.txt (right): https://codereview.chromium.org/1216923008/diff/1/sky/tests/examples/sector-expected.txt#newcode150 sky/tests/examples/sector-expected.txt:150: 3 | | | | | | | drawRRect(Instance ...

5 years, 5 months ago (2015-07-01 22:52:44 UTC) #2

Matt Perry

5 years, 5 months ago (2015-07-01 23:02:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d31b9084a537e1474756ed54deb06f23e066168d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages