remoting/base/breakpad_win_unittest.cc - Issue 1216903002: clang/win: Build without -Wno-null-dereference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/base/breakpad_win_unittest.cc

Issue 1216903002: clang/win: Build without -Wno-null-dereference. (Closed) Base URL: ssh://sammc-z620-l.syd/usr/local/google/home/sammc/chrome/src@clang

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/base/breakpad_win_unittest.cc

diff --git a/remoting/base/breakpad_win_unittest.cc b/remoting/base/breakpad_win_unittest.cc

index 78ab02ab198f6fd5fe4310084ee7a01e59775efe..877ea32adfa2d2e4a2039228f006bcfd4626626f 100644

--- a/remoting/base/breakpad_win_unittest.cc

+++ b/remoting/base/breakpad_win_unittest.cc

@@ -144,7 +144,7 @@ TEST_F(BreakpadWinDeathTest, TestAccessViolation) {

}

// Generate access violation exception.

- ASSERT_DEATH(*reinterpret_cast<int*>(NULL) = 1, "");

+ ASSERT_DEATH(*reinterpret_cast<volatile int*>(NULL) = 1, "");

}

TEST_F(BreakpadWinDeathTest, TestInvalidParameter) {

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »