Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216903002: clang/win: Build without -Wno-null-dereference. (Closed)

Created:
5 years, 5 months ago by Sam McNally
Modified:
5 years, 5 months ago
Reviewers:
Lambros, Nico, Jamie
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, chromoting-reviews_chromium.org, wfh+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
ssh://sammc-z620-l.syd/usr/local/google/home/sammc/chrome/src@clang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Build without -Wno-null-dereference. BUG=505300 Committed: https://crrev.com/6f856f785833aae16732c3573ef4174561ce7de4 Cr-Commit-Position: refs/heads/master@{#336717}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/win/win_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/base/breakpad_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam McNally
jamiewalch@chromium.org: Please review changes in remoting. thakis@chromium.org: Please review changes in base and build.
5 years, 5 months ago (2015-06-29 10:28:33 UTC) #3
Nico
lgtm That was easy :-) Just to check, you built all targets (`ninja -C out\Debug`), ...
5 years, 5 months ago (2015-06-29 14:08:58 UTC) #4
Lambros
remoting lgtm
5 years, 5 months ago (2015-06-29 16:43:59 UTC) #6
Sam McNally
On 2015/06/29 14:08:58, Nico wrote: > That was easy :-) Just to check, you built ...
5 years, 5 months ago (2015-06-30 01:02:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216903002/20001
5 years, 5 months ago (2015-06-30 01:04:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-06-30 02:11:31 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 02:12:28 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6f856f785833aae16732c3573ef4174561ce7de4
Cr-Commit-Position: refs/heads/master@{#336717}

Powered by Google App Engine
This is Rietveld 408576698