Move logic of gyp_chromium into gyp_chromium.py

Move logic of gyp_chromium into gyp_chromium.py

For historical reasons gyp_chromium.py was launcher script
for gyp_chromium and the python logic lived in the
gyp_chromium.  This change moves python code into the
.py file makes the extension-free gyp_chromium a launcher
for gyp_chromium.py.

Committed: https://crrev.com/1eeaa328a6e7d621857c0026d0a2dd448dbf0f65
Cr-Commit-Position: refs/heads/master@{#342887}

[Sam Clegg, 2015-07-07 18:35:46]

sbc@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sam Clegg, 2015-07-07 18:37:01]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 18:38:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216863010/40001

[commit-bot: I haz the power, 2015-07-07 19:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 19:43:33]

Dry run: This issue passed the CQ dry run.

[scottmg, 2015-08-10 19:09:06]

Sorry for the very long delay, was on vacation.

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium#newc...
build/gyp_chromium:7: # TODO(sbc): This should probably be shell script but for
historical
I don't think we should change it to a shell script as it's basically only being
maintained for "command line api" so everywhere will be running it as "python
build/gyp_chromium" anyway.

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium#newc...
build/gyp_chromium:9: # a .py extension) it currently still python.
missing a word here

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium#newc...
build/gyp_chromium:11: execfile(__file__ + '.py')
i'm not sure about the value of __file__, does this need to be abspath'd?

[Sam Clegg, 2015-08-11 16:54:42]

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium#newc...
build/gyp_chromium:7: # TODO(sbc): This should probably be shell script but for
historical
On 2015/08/10 19:09:06, scottmg (returning - slow) wrote:
> I don't think we should change it to a shell script as it's basically only
being
> maintained for "command line api" so everywhere will be running it as "python
> build/gyp_chromium" anyway.

I agree, and I've updated the comment.  However, in the long run those callers
should use "python build/gyp_chromium.py".  Probably this will never happen, but
files without extensions are normally launcher scripts (shell scripts) (at least
in depot_tools that is the convention).  Plus execfile() is kinda gross.

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium#newc...
build/gyp_chromium:9: # a .py extension) it currently still python.
On 2015/08/10 19:09:06, scottmg (returning - slow) wrote:
> missing a word here

Done.

https://codereview.chromium.org/1216863010/diff/40001/build/gyp_chromium#newc...
build/gyp_chromium:11: execfile(__file__ + '.py')
On 2015/08/10 19:09:06, scottmg (returning - slow) wrote:
> i'm not sure about the value of __file__, does this need to be abspath'd?

__file__ should work fine here.. as along there is no chdir() preceding.. and if
there was a chdir() preceding then even abspath wouldn't help.

[Sam Clegg, 2015-08-11 16:54:48]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 16:55:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216863010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1216863010/60001

[scottmg, 2015-08-11 16:57:44]

lgtm

[commit-bot: I haz the power, 2015-08-11 19:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 19:15:50]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2015-08-11 20:21:15]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-08-11 20:22:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216863010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1216863010/60001

[commit-bot: I haz the power, 2015-08-11 21:01:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-11 21:02:28]

Patchset 4 (id:??) landed as
https://crrev.com/1eeaa328a6e7d621857c0026d0a2dd448dbf0f65
Cr-Commit-Position: refs/heads/master@{#342887}