Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: sky/sdk/lib/rendering/box.dart

Issue 1216833003: Make rendering use PaintingNodes for increased efficiency. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Feedback fixes plus missing critical line that makes it work Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/rendering/box.dart
diff --git a/sky/sdk/lib/rendering/box.dart b/sky/sdk/lib/rendering/box.dart
index aac7bbea44ca32bef32d1fd7e994195d282a3d56..65bdd7dae7c37eb559bb0829e00a72620d500831 100644
--- a/sky/sdk/lib/rendering/box.dart
+++ b/sky/sdk/lib/rendering/box.dart
@@ -429,6 +429,8 @@ abstract class RenderBox extends RenderObject {
_size = inDebugBuild ? new _DebugSize(value, this, debugCanParentUseSize) : value;
}
+ Rect get paintBounds => Point.origin & size;
+
String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}size: ${size}\n';
}
@@ -1351,18 +1353,17 @@ class RenderView extends RenderObject with RenderObjectWithChildMixin<RenderBox>
void paintFrame() {
sky.tracing.begin('RenderView.paintFrame');
- RenderObject.debugDoingPaint = true;
try {
sky.PictureRecorder recorder = new sky.PictureRecorder();
- PaintingCanvas canvas = new PaintingCanvas(recorder, _size);
- paint(canvas, Offset.zero);
+ PaintingCanvas canvas = new PaintingCanvas(recorder, paintBounds);
+ canvas.drawPaintingNode(paintingNode);
sky.view.picture = recorder.endRecording();
} finally {
- RenderObject.debugDoingPaint = false;
sky.tracing.end('RenderView.paintFrame');
}
}
+ Rect get paintBounds => Point.origin & size;
}
// HELPER METHODS FOR RENDERBOX CONTAINERS

Powered by Google App Engine
This is Rietveld 408576698