Make rendering use PaintingNodes for increased efficiency.

sky/engine/core/painting/PaintingNode.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SKY_ENGINE_CORE_PAINTING_PAINTINGNODE_H_
+#define SKY_ENGINE_CORE_PAINTING_PAINTINGNODE_H_
+
+#include "sky/engine/core/painting/Drawable.h"
+#include "sky/engine/tonic/dart_wrappable.h"
+#include "sky/engine/wtf/PassRefPtr.h"
+#include "sky/engine/wtf/RefCounted.h"
+#include "third_party/skia/include/core/SkDrawable.h"
+
+namespace blink {
+
+class PaintingNodeDrawable : public SkDrawable {
+public:
+    static PassRefPtr<PaintingNodeDrawable> create(PassRefPtr<SkDrawable> skDrawable);
+    static PassRefPtr<PaintingNodeDrawable> create();
+
+    ~PaintingNodeDrawable() override {}

[abarth-chromium, 2015/07/06 20:50:57]

nit: we usually put virtual destructors out-of-line.

[iansf, 2015/07/07 21:11:22]

Done.

+
+    SkRect onGetBounds();

[abarth-chromium, 2015/07/06 20:50:57]

override?

[iansf, 2015/07/07 21:11:22]

Done.

+    void onDraw(SkCanvas* canvas);
+    SkPicture* onNewPictureSnapshot();

[abarth-chromium, 2015/07/06 20:50:57]

override?

[iansf, 2015/07/07 21:11:22]

Done.

+    void set_drawable(PassRefPtr<SkDrawable> drawable) { m_drawable = drawable; }
+
+private:
+    PaintingNodeDrawable();
+    explicit PaintingNodeDrawable(PassRefPtr<SkDrawable> skDrawable);
+    RefPtr<SkDrawable> m_drawable;
+};
+
+
+
+
+class PaintingNode : public RefCounted<PaintingNode>, public DartWrappable {

[abarth-chromium, 2015/07/06 20:50:57]

We prefer one class per file.  Would you be willing to put these classes in
separate files?

[iansf, 2015/07/07 21:11:22]

Done.

+    DEFINE_WRAPPERTYPEINFO();
+public:
+    static PassRefPtr<PaintingNode> create();
+    ~PaintingNode() override;
+
+    void setBackingDrawable(PassRefPtr<Drawable> drawable) {
+        m_paintingNodeDrawable->set_drawable(drawable->toSkia());
+    }
+    SkDrawable* toSkia() { return m_paintingNodeDrawable.get(); }
+
+private:
+    PaintingNode();
+    PassRefPtr<Picture> newPictureSnapshot();

[abarth-chromium, 2015/07/06 20:50:57]

Does anyone call this function?  If not, we should remove it.

[iansf, 2015/07/07 21:11:22]

I made this public and put in into the idl, although it isn't being used yet in
any sample code or framework code.

+    RefPtr<PaintingNodeDrawable> m_paintingNodeDrawable;
+};
+
+} // namespace blink
+
+#endif  // SKY_ENGINE_CORE_PAINTING_PAINTINGNODE_H_