Make rendering use PaintingNodes for increased efficiency.

sky/engine/core/painting/PaintingNode.cpp

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "sky/engine/core/painting/PaintingNode.h"
+#include "sky/engine/core/painting/Picture.h"
+
+namespace blink {
+
+// static
+PassRefPtr<PaintingNodeDrawable> PaintingNodeDrawable::create()
+{
+    return adoptRef(new PaintingNodeDrawable());
+}
+
+PassRefPtr<PaintingNodeDrawable> PaintingNodeDrawable::create(PassRefPtr<SkDrawable> skDrawable)
+{
+    return adoptRef(new PaintingNodeDrawable(skDrawable));
+}
+
+PaintingNodeDrawable::PaintingNodeDrawable()
+    : m_drawable(nullptr)
+{
+}
+
+PaintingNodeDrawable::PaintingNodeDrawable(PassRefPtr<SkDrawable> skDrawable)
+    : m_drawable(skDrawable)
+{
+}

[abarth-chromium, 2015/07/06 20:50:57]

Rather than having two constructors, we could just have one that takes a
PassRefPtr<SkDrawable>.  We can then delete PaintingNodeDrawable::create() and
just have the other |create| function default to nullptr:

PaintingNodeDrawable::create(PassRefPtr<SkDrawable> skDrawable = nullptr)

[iansf, 2015/07/07 21:11:22]

Done.

+
+SkPicture* PaintingNodeDrawable::onNewPictureSnapshot()
+{
+    if (!m_drawable)
+        return nullptr;
+    return m_drawable->newPictureSnapshot();
+}
+
+SkRect PaintingNodeDrawable::onGetBounds()
+{
+    if (!m_drawable)
+        return SkRect::MakeEmpty();
+    return m_drawable->getBounds();
+}
+
+void PaintingNodeDrawable::onDraw(SkCanvas* canvas)
+{
+    if (!m_drawable)
+        return;
+    return m_drawable->draw(canvas);
+}
+
+
+
+
+PassRefPtr<PaintingNode> PaintingNode::create()
+{
+    return adoptRef(new PaintingNode());
+}
+
+PaintingNode::PaintingNode()
+    : m_paintingNodeDrawable(PaintingNodeDrawable::create())
+{
+}
+
+PassRefPtr<Picture> PaintingNode::newPictureSnapshot()
+{
+    assert(m_paintingNodeDrawable);

[abarth-chromium, 2015/07/06 20:50:57]

s/assert/ASSERT/

ASSERT is a macro we define that has better logging than assert.

[iansf, 2015/07/07 20:36:47]

Done.

+    return Picture::create(
+        adoptRef(m_paintingNodeDrawable->newPictureSnapshot()));
+}
+
+PaintingNode::~PaintingNode()
+{
+}
+
+} // namespace blink