Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1216833002: Meaningful name for builtins in JitCodeEvent API. (Closed)

Created:
5 years, 5 months ago by bnoordhuis
Modified:
5 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Meaningful name for builtins in JitCodeEvent API. Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline") instead of labeling everything "Builtin:A builtin from the snapshot". BUG= Committed: https://crrev.com/f7969b1d5a55e66237221a463daf422ac7611788 Cr-Commit-Position: refs/heads/master@{#29339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bnoordhuis
5 years, 5 months ago (2015-06-27 15:26:15 UTC) #2
Sven Panne
lgtm
5 years, 5 months ago (2015-06-29 06:56:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216833002/1
5 years, 5 months ago (2015-06-29 06:57:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 07:36:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 07:37:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7969b1d5a55e66237221a463daf422ac7611788
Cr-Commit-Position: refs/heads/master@{#29339}

Powered by Google App Engine
This is Rietveld 408576698