Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 121673003: Switch exit status from 77 (try again later) back to 12/13 (errors) (Closed)

Created:
6 years, 11 months ago by Mark Mentovai
Modified:
6 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Switch exit status from 77 (try again later) back to 12/13 (errors). When driving an update from KeystoneRegistration, Chrome sees 77 as success. This causes the about page to say that an update was successfully installed and offer the option to relaunch. When the user clicks Relaunch, Chrome quits and the same old version restarts and starts trying to apply an update again. This seems kind of glitchy. I'm switching back to the failure codes, because those are properly reported in the UI. In the future, I can make keystone_glue.mm check for the .want_full_installer file when update installation fails and silently retry installation once, for a seamless "error 12"-free experience. BUG=54047, 303280 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/installer/mac/keystone_install.sh View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
TBR (hopefully I can get this in before tomorrow’s canary builds).
6 years, 11 months ago (2014-01-05 05:17:55 UTC) #1
Mark Mentovai
6 years, 11 months ago (2014-01-05 05:18:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r243035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698