Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1216703003: [android] Remove unpack library fallback. (Closed)

Created:
5 years, 5 months ago by rmcilroy
Modified:
5 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, android-webview-reviews_chromium.org, asvitkine+watch_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, erikwright+watch_chromium.org, gunsch+watch_chromium.org, jam, jochen+watch_chromium.org, lcwu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Remove unpack library fallback. The load library from APK configuration of Chrome is only going to be used on version of Lollipop onwards where there should be no need to trigger the unpack fallback. UMA shows no use of this fallback in the wild, so let's remove it. BUG=398425, 390618 Committed: https://crrev.com/5bdee9ce280c64269fefea901c08f98d90adb232 Cr-Commit-Position: refs/heads/master@{#337222}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix MojoApplication and ServiceRegistryTest #

Patch Set 4 : Tweak documentation to not allow null context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -599 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 1 2 3 8 chunks +13 lines, -83 lines 0 comments Download
D base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java View 1 chunk +0 lines, -338 lines 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 3 chunks +0 lines, -58 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/metrics/RecordHistogramTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M base/android/linker/linker_jni.cc View 1 2 chunks +1 line, -59 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ServiceRegistryTest.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/android/browsertests/src/org/chromium/content_shell/browsertests/ContentShellBrowserTestActivity.java View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/MojoTestCase.java View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellApplication.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/android_crazy_linker/README.chromium View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/android_crazy_linker/src/include/crazy_linker.h View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_api.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 40 (17 generated)
rmcilroy
Simon / Orion, PTAL, thanks.
5 years, 5 months ago (2015-07-01 16:43:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216703003/1
5 years, 5 months ago (2015-07-01 16:45:07 UTC) #4
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-07-01 16:48:19 UTC) #6
simonb (inactive)
LGTM from the crazy linker perspective. I didn't realize this thing had so many tentacles. ...
5 years, 5 months ago (2015-07-01 17:18:23 UTC) #7
rmcilroy
On 2015/07/01 17:18:23, simonb wrote: > LGTM from the crazy linker perspective. I didn't realize ...
5 years, 5 months ago (2015-07-01 19:58:11 UTC) #8
rmcilroy
torne@ please review files in aw/ davidben@ please review files in net/ jochen@ please review ...
5 years, 5 months ago (2015-07-01 20:03:51 UTC) #10
rmcilroy
-jamesr (sorry about the noise) sky@ please review change in mojo/ gunsch@ please review change ...
5 years, 5 months ago (2015-07-01 20:10:41 UTC) #12
gunsch
rs lgtm for chromecast, though it's never encouraging seeing a CL with the try results ...
5 years, 5 months ago (2015-07-01 20:11:59 UTC) #14
rmcilroy
On 2015/07/01 20:11:59, gunsch wrote: > rs lgtm for chromecast, Thanks > though it's never ...
5 years, 5 months ago (2015-07-01 20:18:44 UTC) #15
davidben
net lgtm
5 years, 5 months ago (2015-07-01 20:21:03 UTC) #16
sky
LGTM
5 years, 5 months ago (2015-07-01 20:51:29 UTC) #17
Ilya Sherman
histograms.xml lgtm
5 years, 5 months ago (2015-07-01 23:34:22 UTC) #18
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-02 07:01:42 UTC) #19
petrcermak
LGTM. Thanks, Petr
5 years, 5 months ago (2015-07-02 08:07:34 UTC) #20
Torne
android_webview LGTM
5 years, 5 months ago (2015-07-02 09:21:42 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216703003/20001
5 years, 5 months ago (2015-07-02 10:23:46 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/104371)
5 years, 5 months ago (2015-07-02 10:35:35 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216703003/40001
5 years, 5 months ago (2015-07-02 12:33:26 UTC) #29
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-07-02 12:52:50 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216703003/60001
5 years, 5 months ago (2015-07-02 13:15:51 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216703003/80001
5 years, 5 months ago (2015-07-02 13:53:20 UTC) #38
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 5 months ago (2015-07-02 15:00:50 UTC) #39
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 15:02:10 UTC) #40
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5bdee9ce280c64269fefea901c08f98d90adb232
Cr-Commit-Position: refs/heads/master@{#337222}

Powered by Google App Engine
This is Rietveld 408576698