Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1216673011: SkyDemo.apk should be able to launch Stocks offline (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

SkyDemo.apk should be able to launch Stocks offline We now put stocks.skyx into the APK so that we can run it offline. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f93dc6c4100d11c77479a27cbe19d3d9ee9692b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M sky/build/sky_app.gni View 2 chunks +26 lines, -1 line 0 comments Download
M sky/sdk/example/demo_launcher/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-07 00:30:23 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-07-07 00:31:16 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-07 00:53:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f93dc6c4100d11c77479a27cbe19d3d9ee9692b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698