Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 1216673007: [Password Manager] It's a follow-cl in "chrome/app/generated_resources.grd". "passwo rd" -> password (Closed)

Created:
5 years, 5 months ago by Pritam Nikam
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] It's a follow-up cl in |chrome/app/generated_resources.grd|. "passwo rd" -> "password" BUG=435152 Committed: https://crrev.com/8744337afafdf37d2a023f81f4d6a962c5f61bb7 Cr-Commit-Position: refs/heads/master@{#337610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Pritam Nikam
On 2015/07/06 20:37:51, Pritam Nikam wrote: > mailto:pritam.nikam@samsung.com changed reviewers: > + mailto:lgarron@chromium.org, mailto:vabr@chromium.org Thanks ...
5 years, 5 months ago (2015-07-06 20:40:26 UTC) #2
lgarron
LGTM, although you'll need someone else's LGTM to land. :-)
5 years, 5 months ago (2015-07-07 01:41:24 UTC) #3
vabr (Chromium)
No need for another approval -- the changed file is OWNED by everyone. LGTM nevertheless! ...
5 years, 5 months ago (2015-07-07 13:00:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216673007/1
5 years, 5 months ago (2015-07-07 13:26:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/70212) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 5 months ago (2015-07-07 13:35:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216673007/1
5 years, 5 months ago (2015-07-07 14:55:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 15:55:56 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 15:56:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8744337afafdf37d2a023f81f4d6a962c5f61bb7
Cr-Commit-Position: refs/heads/master@{#337610}

Powered by Google App Engine
This is Rietveld 408576698