ui/views/focus/focus_manager_unittest.cc - Issue 1216673005: views::LabelButton should not call virtual methods from its constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/focus/focus_manager_unittest.cc

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor

Patch Set: self review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/focus/focus_manager_unittest.cc

diff --git a/ui/views/focus/focus_manager_unittest.cc b/ui/views/focus/focus_manager_unittest.cc

index c9032644ba37c08c9f8e9196aaab83007aaff16a..bc7887174e654a6b6159bf8c3503553375ce4ed5 100644

--- a/ui/views/focus/focus_manager_unittest.cc

+++ b/ui/views/focus/focus_manager_unittest.cc

@@ -526,9 +526,8 @@ class FocusManagerDtorTest : public FocusManagerTest {

public:

LabelButtonDtorTracked(const base::string16& text,

DtorTrackVector* dtor_tracker)

- : LabelButton(NULL, text),

- dtor_tracker_(dtor_tracker) {

- SetStyle(STYLE_BUTTON);

+ : LabelButton(nullptr), dtor_tracker_(dtor_tracker) {

+ InitAsButton(text);

};

~LabelButtonDtorTracked() override {

dtor_tracker_->push_back("LabelButtonDtorTracked");

« no previous file with comments | « ui/views/controls/button/menu_button.cc ('k') | ui/views/focus/focus_traversal_unittest.cc » ('j') | no next file with comments »