ui/views/controls/button/custom_button_unittest.cc - Issue 1216673005: views::LabelButton should not call virtual methods from its constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/custom_button_unittest.cc

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor

Patch Set: self review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/custom_button_unittest.cc

diff --git a/ui/views/controls/button/custom_button_unittest.cc b/ui/views/controls/button/custom_button_unittest.cc

index de3be98fe5541c63730f7c00a7ab67cf52cfcee3..e52d3d0a6d49f26fdf91d415c64c7a76492e257a 100644

--- a/ui/views/controls/button/custom_button_unittest.cc

+++ b/ui/views/controls/button/custom_button_unittest.cc

@@ -215,7 +215,8 @@ TEST_F(CustomButtonTest, GestureEventsSetState) {

TEST_F(CustomButtonTest, AsCustomButton) {

base::string16 text;

- LabelButton label_button(NULL, text);

+ LabelButton label_button(nullptr);

+ label_button.InitAsTextbutton(text);

EXPECT_TRUE(CustomButton::AsCustomButton(&label_button));

ImageButton image_button(NULL);

« no previous file with comments | « ui/views/controls/button/checkbox.cc ('k') | ui/views/controls/button/label_button.h » ('j') | no next file with comments »