Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: ui/views/controls/button/blue_button.cc

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor
Patch Set: self review Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/blue_button.h ('k') | ui/views/controls/button/blue_button_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/blue_button.cc
diff --git a/ui/views/controls/button/blue_button.cc b/ui/views/controls/button/blue_button.cc
index 81855561699a0af4eeaa0ef0d0e872a7827bed6c..ee9bbe535facfb851b5c425bde79bf27a50d9427 100644
--- a/ui/views/controls/button/blue_button.cc
+++ b/ui/views/controls/button/blue_button.cc
@@ -17,10 +17,8 @@ namespace views {
const char BlueButton::kViewClassName[] = "views/BlueButton";
BlueButton::BlueButton(ButtonListener* listener, const base::string16& text)
- : LabelButton(listener, text) {
- // Inherit STYLE_BUTTON insets, minimum size, alignment, etc.
- SetStyle(STYLE_BUTTON);
- UpdateThemedBorder();
+ : LabelButton(listener) {
+ InitAsButton(text);
}
BlueButton::~BlueButton() {}
« no previous file with comments | « ui/views/controls/button/blue_button.h ('k') | ui/views/controls/button/blue_button_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698