views::LabelButton should not call virtual methods from its constructor

ui/views/controls/button/checkbox.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/checkbox.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/views/controls/button/label_button_border.h"
 #include "ui/views/painter.h"
 #include "ui/views/resources/grit/views_resources.h"
 
 namespace views {
 
 // static
 const char Checkbox::kViewClassName[] = "Checkbox";
 
 Checkbox::Checkbox(const base::string16& label)
-    : LabelButton(NULL, label),
-      checked_(false) {
+    : LabelButton(nullptr), checked_(false) {
   SetHorizontalAlignment(gfx::ALIGN_LEFT);
-  scoped_ptr<LabelButtonBorder> button_border(new LabelButtonBorder(style()));
+  scoped_ptr<LabelButtonBorder> button_border(
+      new LabelButtonBorder(STYLE_TEXTBUTTON));
   button_border->SetPainter(false, STATE_HOVERED, NULL);
   button_border->SetPainter(false, STATE_PRESSED, NULL);
   // Inset the trailing side by a couple pixels for the focus border.
   button_border->set_insets(gfx::Insets(0, 0, 0, 2));
   SetBorder(button_border.Pass());
+
+  // TODO(tapted): Remove this. Checkbox has subclasses and Init() may call
+  // virtual methods.
+  InitAsTextbutton(label);
+
   SetFocusable(true);
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
 
   // Unchecked/Unfocused images.
   SetCustomImage(false, false, STATE_NORMAL,
                  *rb.GetImageSkiaNamed(IDR_CHECKBOX));
   SetCustomImage(false, false, STATE_HOVERED,
                  *rb.GetImageSkiaNamed(IDR_CHECKBOX_HOVER));
   SetCustomImage(false, false, STATE_PRESSED,
@@ skipping 100 matching lines @@
 ui::NativeTheme::Part Checkbox::GetThemePart() const {
   return ui::NativeTheme::kCheckbox;
 }
 
 void Checkbox::GetExtraParams(ui::NativeTheme::ExtraParams* params) const {
   LabelButton::GetExtraParams(params);
   params->button.checked = checked_;
 }
 
 }  // namespace views