Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Side by Side Diff: ui/views/controls/button/blue_button.h

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor
Patch Set: self review Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/button_drag_utils.cc ('k') | ui/views/controls/button/blue_button.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_ 5 #ifndef UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_
6 #define UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_ 6 #define UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "ui/views/controls/button/label_button.h" 9 #include "ui/views/controls/button/label_button.h"
10 10
11 namespace views { 11 namespace views {
12 12
13 // A class representing a blue button. 13 // A class representing a blue button. Declared final because the constructor
14 class VIEWS_EXPORT BlueButton : public LabelButton { 14 // calls virtual methods.
15 class VIEWS_EXPORT BlueButton final : public LabelButton {
15 public: 16 public:
16 static const char kViewClassName[]; 17 static const char kViewClassName[];
17 18
19 // Constructs a BlueButton and initializes with LabelButton::InitAsButton().
18 BlueButton(ButtonListener* listener, const base::string16& text); 20 BlueButton(ButtonListener* listener, const base::string16& text);
21
19 ~BlueButton() override; 22 ~BlueButton() override;
20 23
21 private: 24 private:
22 // Overridden from LabelButton: 25 // Overridden from LabelButton:
23 void ResetColorsFromNativeTheme() override; 26 void ResetColorsFromNativeTheme() override;
24 const char* GetClassName() const override; 27 const char* GetClassName() const override;
25 scoped_ptr<LabelButtonBorder> CreateDefaultBorder() const override; 28 scoped_ptr<LabelButtonBorder> CreateDefaultBorder() const override;
26 29
27 DISALLOW_COPY_AND_ASSIGN(BlueButton); 30 DISALLOW_COPY_AND_ASSIGN(BlueButton);
28 }; 31 };
29 32
30 } // namespace views 33 } // namespace views
31 34
32 #endif // UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_ 35 #endif // UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_
OLDNEW
« no previous file with comments | « ui/views/button_drag_utils.cc ('k') | ui/views/controls/button/blue_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698