views::LabelButton should not call virtual methods from its constructor

ui/views/accessible_pane_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessible_pane_view.h"
 
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/test/views_test_base.h"
@@ skipping 17 matching lines @@
   LabelButton* second_child_button() const {
     return second_child_button_.get();
   }
   LabelButton* third_child_button() const { return third_child_button_.get(); }
   LabelButton* not_child_button() const { return not_child_button_.get(); }
 
   View* GetDefaultFocusableChild() override;
 
  private:
   void Init();
+  LabelButton* CreateButton(bool add);
 
   scoped_ptr<LabelButton> child_button_;
   scoped_ptr<LabelButton> second_child_button_;
   scoped_ptr<LabelButton> third_child_button_;
   scoped_ptr<LabelButton> not_child_button_;
 
   DISALLOW_COPY_AND_ASSIGN(TestBarView);
 };
 
 TestBarView::TestBarView() {
   Init();
   set_allow_deactivate_on_esc(true);
 }
 
 TestBarView::~TestBarView() {}
 
 void TestBarView::ButtonPressed(Button* sender, const ui::Event& event) {
 }
 
 void TestBarView::Init() {
   SetLayoutManager(new FillLayout());
-  base::string16 label;
-  child_button_.reset(new LabelButton(this, label));
-  AddChildView(child_button_.get());
-  second_child_button_.reset(new LabelButton(this, label));
-  AddChildView(second_child_button_.get());
-  third_child_button_.reset(new LabelButton(this, label));
-  AddChildView(third_child_button_.get());
-  not_child_button_.reset(new LabelButton(this, label));
+  child_button_.reset(CreateButton(true));
+  second_child_button_.reset(CreateButton(true));
+  third_child_button_.reset(CreateButton(true));
+  not_child_button_.reset(CreateButton(false));
+}
+
+LabelButton* TestBarView::CreateButton(bool add) {
+  LabelButton* button = new LabelButton(this);
+  button->InitAsTextbutton(base::string16());
+  if (add)
+    AddChildView(button);
+  return button;
 }
 
 View* TestBarView::GetDefaultFocusableChild() {
   return child_button_.get();
 }
 
 TEST_F(AccessiblePaneViewTest, SimpleSetPaneFocus) {
   TestBarView* test_view = new TestBarView();
   scoped_ptr<Widget> widget(new Widget());
   Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
@@ skipping 137 matching lines @@
             test_view->GetWidget()->GetFocusManager()->GetFocusedView());
 
   // ESC
   test_view->AcceleratorPressed(test_view->escape_key());
   EXPECT_EQ(original_test_view->third_child_button(),
             test_view->GetWidget()->GetFocusManager()->GetFocusedView());
   widget->CloseNow();
   widget.reset();
 }
 }  // namespace views