views::LabelButton should not call virtual methods from its constructor

ui/views/controls/button/label_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/label_button.h"
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "ui/gfx/animation/throb_animation.h"
 #include "ui/gfx/canvas.h"
@@ skipping 41 matching lines @@
 }  // namespace
 
 namespace views {
 
 // static
 const int LabelButton::kHoverAnimationDurationMs = 170;
 
 // static
 const char LabelButton::kViewClassName[] = "LabelButton";
 
-LabelButton::LabelButton(ButtonListener* listener, const base::string16& text)
+LabelButton::LabelButton(ButtonListener* listener)
     : CustomButton(listener),
       image_(new ImageView()),
       label_(new Label()),
       cached_normal_font_list_(GetDefaultNormalFontList()),
       cached_bold_font_list_(GetDefaultBoldFontList()),
       button_state_images_(),
       button_state_colors_(),
       explicitly_set_colors_(),
       is_default_(false),
-      style_(STYLE_TEXTBUTTON),
+      style_(STYLE_COUNT),  // Something invalid to ensure Init() is called.
       border_is_themed_border_(true),
       image_label_spacing_(kSpacing) {
   SetAnimationDuration(kHoverAnimationDurationMs);
-  SetText(text);
 
   AddChildView(image_);
   image_->set_interactive(false);
 
   AddChildView(label_);
   label_->SetFontList(cached_normal_font_list_);
   label_->SetAutoColorReadabilityEnabled(false);
   label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
-
-  // Initialize the colors, border, and layout.
-  SetStyle(style_);
-
-  SetAccessibleName(text);
 }
 
-LabelButton::~LabelButton() {}
+LabelButton::LabelButton(ButtonListener* listener, const base::string16& text)
+    : LabelButton(listener) {
+  Init(text);
+}
+
+LabelButton::~LabelButton() {
+}
+
+void LabelButton::InitAsButton(const base::string16& text) {
+  SetDefaultStyle(STYLE_BUTTON);
+  Init(text);
+}
+
+void LabelButton::Init(const base::string16& text) {
+  SetText(text);
+  SetStyle(style_ == STYLE_COUNT ? STYLE_TEXTBUTTON : style_);
+}
 
 const gfx::ImageSkia& LabelButton::GetImage(ButtonState for_state) {
   if (for_state != STATE_NORMAL && button_state_images_[for_state].isNull())
     return button_state_images_[STATE_NORMAL];
   return button_state_images_[for_state];
 }
 
 void LabelButton::SetImage(ButtonState for_state, const gfx::ImageSkia& image) {
   button_state_images_[for_state] = image;
   UpdateImage();
@@ skipping 241 matching lines @@
 scoped_ptr<LabelButtonBorder> LabelButton::CreateDefaultBorder() const {
   return make_scoped_ptr(new LabelButtonBorder(style_));
 }
 
 void LabelButton::SetBorder(scoped_ptr<Border> border) {
   border_is_themed_border_ = false;
   View::SetBorder(border.Pass());
   ResetCachedPreferredSize();
 }
 
+void LabelButton::SetDefaultStyle(ButtonStyle style) {
+  style_ = style;
+}
+
 gfx::Rect LabelButton::GetChildAreaBounds() {
   return GetLocalBounds();
 }
 
 void LabelButton::OnPaint(gfx::Canvas* canvas) {
+  DCHECK_NE(STYLE_COUNT, style_) << "LabelButton::Init() not called.";
   View::OnPaint(canvas);
   Painter::PaintFocusPainter(this, canvas, focus_painter_.get());
 }
 
 void LabelButton::OnFocus() {
   View::OnFocus();
   // Typically the border renders differently when focused.
   SchedulePaint();
 }
 
@@ skipping 147 matching lines @@
   GetExtraParams(params);
   return ui::NativeTheme::kHovered;
 }
 
 void LabelButton::ResetCachedPreferredSize() {
   cached_preferred_size_valid_ = false;
   cached_preferred_size_ = gfx::Size();
 }
 
 }  // namespace views