Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1216643007: Add test for time resolution of User Timing (Closed)

Created:
5 years, 5 months ago by Kunihiko Sakamoto
Modified:
5 years, 5 months ago
Reviewers:
inferno
CC:
blink-reviews, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add test for time resolution of User Timing Resolution of performance.now() is reduced in r198348 to prevent timing attacks. Since User Timing uses PerformanceBase::now() internally, its resolution should be now 5 microseconds. BUG=506723 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198381

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M LayoutTests/http/tests/misc/webtiming-resolution.html View 1 1 chunk +23 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/misc/webtiming-resolution-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Kunihiko Sakamoto
5 years, 5 months ago (2015-07-07 05:33:06 UTC) #3
inferno
lgtm https://codereview.chromium.org/1216643007/diff/20001/LayoutTests/http/tests/misc/webtiming-resolution.html File LayoutTests/http/tests/misc/webtiming-resolution.html (right): https://codereview.chromium.org/1216643007/diff/20001/LayoutTests/http/tests/misc/webtiming-resolution.html#newcode16 LayoutTests/http/tests/misc/webtiming-resolution.html:16: console.log(t1); I don't think you want this line ...
5 years, 5 months ago (2015-07-07 06:03:46 UTC) #4
Kunihiko Sakamoto
https://codereview.chromium.org/1216643007/diff/20001/LayoutTests/http/tests/misc/webtiming-resolution.html File LayoutTests/http/tests/misc/webtiming-resolution.html (right): https://codereview.chromium.org/1216643007/diff/20001/LayoutTests/http/tests/misc/webtiming-resolution.html#newcode16 LayoutTests/http/tests/misc/webtiming-resolution.html:16: console.log(t1); On 2015/07/07 06:03:46, inferno wrote: > I don't ...
5 years, 5 months ago (2015-07-07 06:08:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216643007/40001
5 years, 5 months ago (2015-07-07 06:09:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/69911)
5 years, 5 months ago (2015-07-07 06:30:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216643007/40001
5 years, 5 months ago (2015-07-07 09:08:47 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 09:12:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198381

Powered by Google App Engine
This is Rietveld 408576698